Mortal Kombat!!

SilverMist · Posted: Wed Mar 26, 2008 7:52 pm Post subject: Mortal Kombat!!

I use the MK add all the time. It's very useful for my rogue and of course it's fun. I was wondering if there is going to be an update to 2.4

I know the addon is old and there is a low chance it will be updated. But I would greatly appreciate it. As far as I know there is no other addon that does all the same things as this one. It lets me know when I've been hit by another player and that's very useful. As well, the combat music has saved my ass a time or two. If I need an alternative and if there is one please let me know.

Rollie · Posted: Thu Mar 27, 2008 5:12 pm Post subject:

I would have to see what all would need to be done if it requires changes for 2.4

hum4n01dtyph00n · Posted: Fri Mar 28, 2008 1:44 pm Post subject:

I would also love to see this mod 'reborn'

It's like my trademark when I crit and "DOMINATING!" comes up. Everyone loves it.

If there's anything I can do to even help you out here I'll do it. Let me know man, the mod is great, needs to be kept going. =)

Thanks

DM. · Posted: Fri Mar 28, 2008 2:15 pm Post subject:

I guess the change to the combat log finally broke Mortal Kombat...
_________________

Click my sig

Hybuir · Posted: Sat Mar 29, 2008 7:30 am Post subject:

new combat log also broke sct Sad

_________________

hum4n01dtyph00n · Posted: Sun Mar 30, 2008 1:42 am Post subject:

This mod neeeeeeeeds to be fixed!

Please! I'll help with anything that needs to be done, just let me know.

mkong409 · Posted: Tue Apr 01, 2008 1:53 pm Post subject:

I've updated MKombat to use the new combat log structure. I'm currently undergoing some testing to make sure it's all working. Once I'm confident it's not doing anything heinous, I'll upload the fixed code.

-Cheers

hum4n01dtyph00n · Posted: Tue Apr 01, 2008 4:22 pm Post subject:

I love you if you make it work.

You will be the god of my mods if you get it working haha.

mkong409 · Posted: Tue Apr 01, 2008 4:27 pm Post subject:

hum4n01dtyph00n · Posted: Tue Apr 01, 2008 4:46 pm Post subject:

Mine is. O_o

Toss me the mods.

mkong409 · Posted: Tue Apr 01, 2008 7:03 pm Post subject:

Okay, I've uploaded it to GoogleCode here:

http://mkombatmod.googlecode.com

Try it out, keeping in mind it's beta. I have not been able to test all of the events, so any feedback would be helpful.

The majority of code is the same, I've only fixed the code that required the new combat log modifications.

Known Issues:
----------------
There is a problem with the "UNIT_DIES" combat log item, which does not report when *YOU* are killed. This is scheduled to be fixed in WoW 2.4.2 as per Blizzard. As such, the events when you are killed will not fire (yet).

Because of the way that the combat log now works, I've found under testing that it's possible to crit and get the <20% sound nearly on top of each other (and sometimes overlapping). I'll be working on this.

I have not done any performance enhancements to the code (yet). Please report any issues with performance and I'll work on optimizing it.

Report any misfires of events or bugs, and I'll work on those as well.

*EDIT* Note new URL

hum4n01dtyph00n · Posted: Wed Apr 02, 2008 11:48 am Post subject:

Ah you are a god among men my friend.

All i need is for it to yell Dominating! when I crit. Will let you know how it goes.

Thank you.

EDIT: I've found one little problem I believe. When I crit, half the time it plays the sound I ask it to, the other half the time it does not. And when it does play the sound, its quite delayed. Any reason why?

Hybuir · Posted: Wed Apr 02, 2008 12:48 pm Post subject:

sounds promising... I'll have to take a look at the code start learning it and such. I hear the guys behind ctmod.net put out a book, gotta look for that too.
_________________

mkong409 · Posted: Wed Apr 02, 2008 1:07 pm Post subject:

hum4n01dtyph00n · Posted: Wed Apr 02, 2008 11:46 pm Post subject:

Nah it's definately that variable in the MKombat.lua

I've logged off for the night, but next time I get on I'll check.

I'm an enhancement shaman, so shit is critting every 4 to 5 seconds for me. I'll change the variable and let you know.

Thanks for the help.

EDIT: Works like a charm, just had to change that value. Just wanted to say thanks again to mkong409 and Rollie.

hum4n01dtyph00n · Posted: Fri Apr 04, 2008 3:04 am Post subject:

Alright, another dilemma I'm having with the sound mod.

I want it to play sounds when I kill players in PvP. Help me out here? It's not working at all.

mkong409 · Posted: Fri Apr 04, 2008 8:42 am Post subject:

hum4n01dtyph00n · Posted: Fri Apr 04, 2008 11:49 am Post subject:

The only sound I'm noticing that plays at all is the crit sound.

In open, bgs, and arena.

mkong409 · Posted: Fri Apr 04, 2008 1:38 pm Post subject:

mkong409 · Posted: Fri Apr 04, 2008 4:46 pm Post subject:

Okay, I found a typo in the original tags which could cause the FLAWLESS sound to not play properly. I also added some debug code to the player death function to help track your issue.

Download the new version here:
http://mkombatmod.googlecode.com

When you install the new version, go into the game and do a:

/mkombat debug on

When you kill mobs, it will now give the conditionals that it sees. When you kill a PvP target, it will give you the type of kill it was (FLAWLESS, SUPERB, etc).

Load this up, and let me know if you are getting the debug messages without the sound playing.

-Cheers